-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refresh tree shortcut #123
Conversation
@jorgerojas26 do you have an idea where and how to close the opened table if it was deleted? I will look tomorrow a bit more into the code base to figure out how it is opened etc but maybe you have an idea already how one could implement that. |
I'm not sure what you mean but maybe you just delete the tab that has the table open. |
- refactored tree node init - new function for reset - reset filter - delete old nodes -> init new nodes - TODO: close table view if table was deleted
Okay I think this is the best I can do. When refreshing, all nodes under the root node get deleted and afterwards re added. |
PR is ready for review |
This is good enough for now, i think. Can you please just change the keybinding from 'r' to 'R'. The reason is, there is a 'R' keymap for the table that refreshes the data, so, to keep consistency let's use 'R' also for the tree. With that change, i'm ready to merge. Thank you very much |
Also, please check and fix the linter issues. |
I will work on it this evening |
- switched from 'r' to 'R' to be more consistent with other refresh shortcuts
I ran the lints locally and had no errors. I think this should be now fixed. Also changed the shortcut from |
This PR should fix #118
To refresh the tree view my idea is to: